fix(corbado_auth_firebase): repair compile error and resolve analyzer issues#253
Merged
Merged
Conversation
The json_serializable / json_annotation versions used need Dart 3.8.0. Constraints are left as-is so consumers on Dart 3.8.0 still resolve the 3.8-compatible json versions rather than being forced to 3.9.0.
Add doc comments for public members, suppress API-breaking lints via ignore directives without changing public APIs, and apply safe local fixes. Generated files and corbado_auth_firebase (broken, separate PR) are out of scope.
… issues Replace removed PasskeyInfo.userAgent with sourceBrowser/sourceOS in the example, add doc comments for public members, exclude generated files from analysis, and suppress prefer_constructors_over_static_methods without changing the public API.
# Conflicts: # packages/corbado_auth/example/pubspec.yaml # packages/corbado_auth_firebase/example/pubspec.yaml # packages/passkeys/passkeys/example/pubspec.yaml # packages/passkeys/passkeys_platform_interface/lib/types/authenticator_selection.dart # packages/passkeys/passkeys_platform_interface/lib/types/authenticator_selection.g.dart # packages/passkeys/passkeys_platform_interface/pubspec.yaml
# Conflicts: # packages/passkeys/passkeys/lib/authenticator.dart
# Conflicts: # packages/corbado_api_client/lib/frontendapi/lib/src/model/block_body_data.dart # packages/corbado_api_client/lib/frontendapi/lib/src/model/process_common.dart # packages/corbado_auth_firebase/analysis_options.yaml # packages/corbado_auth_firebase/example/lib/widgets/passkey_list_item.dart # packages/corbado_auth_firebase/lib/src/services/corbado.dart
- ignore class_used_as_mixin in generated corbado_api_client models - annotate register/authenticate overrides in passkeys authenticator - ignore deprecated customDomain self-use in corbado_auth - use activeColor for Switch to support min Flutter 3.32.0
The checked-in built_value output declared '_$XMixin' as 'abstract class' but used it in a 'with' clause, which the Dart 3 compiler rejects. Convert these to 'mixin' declarations (matching current built_value output) so the generated frontend API client compiles and its tests pass.
The melos 'test' script ran 'dart test' for every package with a test directory, which fails for the Flutter packages that depend on flutter_test. Split it into 'flutter test' for Flutter packages and 'dart test' for pure Dart packages. Also remove the leftover default counter smoke test from the corbado_auth_firebase example.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Repairs
corbado_auth_firebase(previously non-compiling) and brings it to zero analyzer issues, so the whole monorepo now passesmelos run analyze(--fatal-infos).PasskeyInfo.userAgent, which no longer exists. Replaced it with${passkeyInfo.sourceBrowser} on ${passkeyInfo.sourceOS}(the fieldsPasskeyInfonow exposes).///doc comments for public members inexceptions.dart,corbado_auth_firebase.dart, andservices/corbado.dart.credentiallocal in the example (kept the awaited call).// ignore_for_file: prefer_constructors_over_static_methodsforCorbadoService.getInstance.analyzer: exclude: ['**/*.g.dart']to the analysis options, matching the other packages.No public identifiers, file names, or signatures were changed.
Verification
melos run analyzereports 0 issues across the entire repo (this package included).melos run format:checkpasses.Merge order
This is the follow-up to #252. Stacked on #252 → #251 → #250; merge those first and this diff reduces to just the
corbado_auth_firebasechanges.